New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added validation_error_cause to config. #7626
Conversation
please review |
Thanks @zakstucke for this patch 🙏 It would be great to have at least one test for this config flag. Please update |
@hramezani its got quite a few different pathways tested fully in pydantic core. Do you want me to add exception group as a test dep in pydantic as well and test all the different pathways, or something simpler? Pathways:
|
@zakstucke I am thinking about having only the last option( |
@hramezani ok sounds good, just added test for 3.11 modern pathway, disabled and enabled. Please review |
Thanks @zakstucke for refreshing the PR, we will include this in the next release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks @zakstucke for the contribution 😄
@zakstucke, do you want to change the description of this PR to have Fix #6498? instead of just the issue reference? |
@sydney-runkle done! (If I understood you correctly) |
Change Summary
Hooks up
validation_error_cause: bool
config value added to pydantic core.Related issue number
Fix #6498
Checklist
Selected Reviewer: @hramezani