Add test for complicated scenario that was producing schema generation errors #7648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmontagu
changed the title
Deploying with
|
| Latest commit: |
66e30e6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9d738883.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://dmontagu-complex-scenario-te.pydantic-docs2.pages.dev |
dmontagu
commented
Sep 26, 2023
| first: Annotated[Root1 | Root2, Field(discriminator='kind')] | ||
| second: Annotated[Root1 | Root2, Field(discriminator='kind')] | ||
|
|
||
| assert Outer.model_json_schema() == { |
There was a problem hiding this comment.
Prior to #7646, this test fails to even create the Outer class due to a SchemaError. I added the model_json_schema() call though to make sure the generated JSON schema is also correct (which it appears to be), as an additional layer of protection against other bugs that might get introduced in the future with this complex of a model.
adriangb
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test added in this PR fails before #7646, and I think is a fairly minimal example of the issue resolved in that PR.