Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json schema generation for recursive models #7653

Merged
merged 3 commits into from Sep 27, 2023

Conversation

adriangb
Copy link
Member

@adriangb adriangb commented Sep 26, 2023

Fixes #7645

@cloudflare-pages
Copy link

cloudflare-pages bot commented Sep 26, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c10e10c
Status: ✅  Deploy successful!
Preview URL: https://2c51ff3e.pydantic-docs2.pages.dev
Branch Preview URL: https://fix-json-schema-recursive-mo.pydantic-docs2.pages.dev

View logs

@adriangb adriangb self-assigned this Sep 26, 2023
@adriangb adriangb added the relnotes-fix Used for bugfixes. label Sep 26, 2023
@vincentsarago
Copy link

🙏 @adriangb , I can confirm that this fixed the issue I'm seeing in developmentseed/geojson-pydantic#146

@dmontagu dmontagu merged commit 97c0199 into main Sep 27, 2023
60 checks passed
@dmontagu dmontagu deleted the fix-json-schema-recursive-model branch September 27, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(2.4.0/2.4.1) LookupError during schema gen (simple repro)
3 participants