Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for instance method reassignment when extra='allow' #7683

Merged
merged 7 commits into from Oct 2, 2023
Merged

Add support for instance method reassignment when extra='allow' #7683

merged 7 commits into from Oct 2, 2023

Commits on Sep 28, 2023

  1. first pass @ adding support for reassigning instance methods

    @sydney-runkle
    sydney-runkle committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    ea59cab View commit details
    Browse the repository at this point in the history

  2. better naming bc the various conditionals were confusing

    @sydney-runkle
    sydney-runkle committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    44d0323 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. modifying test + modifying logic in __setattr__ to be less hacky + ma… 

    …tch __getattr__ pattern
    @sydney-runkle
    sydney-runkle committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    9b08ecf View commit details
    Browse the repository at this point in the history

  2. using try/catch for getattr check

    @sydney-runkle
    sydney-runkle committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    b8b5b05 View commit details
    Browse the repository at this point in the history

  3. adding explicity test for instance method w two ways of implementing

    @sydney-runkle
    sydney-runkle committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    dbc1ed9 View commit details
    Browse the repository at this point in the history

  4. Remove unneeded tests 

    Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com>
    @sydney-runkle @dmontagu
    sydney-runkle and dmontagu committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    9363d3e View commit details
    Browse the repository at this point in the history

  5. linting post David's test removal suggestion

    @sydney-runkle
    sydney-runkle committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    46db5a7 View commit details
    Browse the repository at this point in the history