fix: update typevar handling when default is not set #7719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe the behaviour change in #7606 is raising false positives when the `default` argument is supported but not specified. Ref: https://peps.python.org/pep-0696/#implementation
|
please review |
adriangb
reviewed
Oct 3, 2023
Comment on lines
1454
to
1455
| if default is None: | ||
| default = not_set |
There was a problem hiding this comment.
Can the default not be None? How does this differentiate default=None from no default?
There was a problem hiding this comment.
According to the PEP:
- when default is unset,
__default__would beNone - if
default=None,__default__would beNoneType
There was a problem hiding this comment.
Can we get rid of our internal unset thing then?
There was a problem hiding this comment.
Hmm, yes - let me try and see if that works
adriangb
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
I believe the behaviour change in #7606 is raising false positives when the
defaultargument is supported but not specified.Ref: https://peps.python.org/pep-0696/#implementation
Related issue number
#7606
Checklist
Selected Reviewer: @Kludex