Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix defer_build behavior with TypeAdapter #7736

Merged
merged 2 commits into from Oct 4, 2023

Conversation

sydney-runkle
Copy link
Member

@sydney-runkle sydney-runkle commented Oct 4, 2023

Change Summary

Fix defer_build behavior with TypeAdapter, see #7727 for details on bug.

Related issue number

Fix #7727

Other Notes

  • Can implement support for defer_build for dataclasses in the future
  • Can reassign serializer and validator attributes of the TypeAdapter in the future

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

@cloudflare-pages
Copy link

cloudflare-pages bot commented Oct 4, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2138418
Status: ✅  Deploy successful!
Preview URL: https://f89e8a10.pydantic-docs2.pages.dev
Branch Preview URL: https://fix-defer-build-with-ta.pydantic-docs2.pages.dev

View logs

@sydney-runkle
Copy link
Member Author

Please review

@sydney-runkle sydney-runkle merged commit fe758e5 into main Oct 4, 2023
60 of 62 checks passed
@sydney-runkle sydney-runkle deleted the fix-defer-build-with-ta branch October 4, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BaseModel with defer_build breaks with TypeAdapter.
3 participants