Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fields.md #7744

Merged
merged 4 commits into from Oct 25, 2023
Merged

Update fields.md #7744

merged 4 commits into from Oct 25, 2023

Conversation

bn-l
Copy link
Contributor

@bn-l bn-l commented Oct 5, 2023 •
edited

Change Summary

Small typo. str() was left out for the alias/vscode warning workaround.

Related issue number

#5893

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @samuelcolvin

@bn-l
Update fields.md
bb92eab 
Small typo here. I believe str() for the alias/vscode warning workaround ([here](pydantic#5893)) was missing.
@bn-l
Copy link
Contributor Author

bn-l commented Oct 9, 2023

please review

sydney-runkle
sydney-runkle approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

Once we get all of the tests passing, I'll merge.

@sydney-runkle sydney-runkle added the relnotes-ignore Omit this PR from the release notes. label Oct 25, 2023
@sydney-runkle sydney-runkle enabled auto-merge (squash) October 25, 2023 16:50
@sydney-runkle sydney-runkle merged commit 0a2d1df into pydantic:main Oct 25, 2023
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees

@samuelcolvin samuelcolvin

Labels
ready for review relnotes-ignore Omit this PR from the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bn-l @sydney-runkle @samuelcolvin