Add option to output unsorted schema #7767
Conversation
- add unit tests
|
@sydney-runkle have tried to create an option for unsorted output. Let me know if this is ok or totally off the mark :) Please review |
There was a problem hiding this comment.
@vigneshmanick - looks great overall - just a few change requests.
Thanks so much for your contribution - I'm sure this feature will be highly appreciated 😄.
| else: | ||
| return json_schema |
There was a problem hiding this comment.
| else: | |
| return json_schema | |
| return json_schema |
| def generate(self, schema, mode='validation', sort_schema=True): | ||
| json_schema = super().generate(schema, mode=mode, sort_schema=sort_schema) |
There was a problem hiding this comment.
Could you add a section to this test that verifies the operation of the sort_schema=False flag in the case of a custom generate json schema function?
There was a problem hiding this comment.
do you mean parameterize the flag?
|
@adriangb, could you take a look at this PR? Others on the team mentioned that you've contributed significantly to the sorting logic, so would love to get your input 😄. |
|
Closing in favor of #7817 |
Change Summary
Add toggle so that the schema output
model_dumpcan be sorted or unsorted. The sorting was added in #6043.Related issue number
#7580
Checklist
Selected Reviewer: @davidhewitt