Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use generated alias for aliases that are not specified otherwise #7802

Merged
merged 3 commits into from Oct 16, 2023
Merged

Use generated alias for aliases that are not specified otherwise #7802

merged 3 commits into from Oct 16, 2023

Conversation

alexmojaki
Copy link
Contributor

@alexmojaki alexmojaki commented Oct 11, 2023 •
edited by pydantic-hooky bot

Change Summary

All three aliases now fallback to the alias generator if there is one and no other value was specified for that alias.

Related issue number

Closes #7781

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @hramezani

@alexmojaki
Copy link
Contributor Author

please review

dmontagu
dmontagu requested changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@dmontagu dmontagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, two small change requests

pydantic/_internal/_generate_schema.py Outdated Show resolved Hide resolved
pydantic/_internal/_generate_schema.py Outdated Show resolved Hide resolved
@pydantic-hooky pydantic-hooky bot assigned alexmojaki and unassigned hramezani Oct 12, 2023
@dmontagu dmontagu added the relnotes-fix Used for bugfixes. label Oct 12, 2023
sydney-runkle
sydney-runkle approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks so much for the contribution! 🌟

@sydney-runkle sydney-runkle enabled auto-merge (squash) October 16, 2023 14:03
@sydney-runkle sydney-runkle merged commit d787222 into pydantic:main Oct 16, 2023
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmontagu dmontagu dmontagu approved these changes

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees

@alexmojaki alexmojaki

Labels
ready for review relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alias Generator not working with Validation Alias
4 participants
@alexmojaki @dmontagu @sydney-runkle @hramezani