Allow plugins to catch non ValidationError errors #7806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangb
commented
Oct 12, 2023
| @@ -58,7 +60,7 @@ class Model(BaseModel, plugin_settings={'observe': 'all'}): | |||
|
|
|||
| def test_on_validate_json_on_error() -> None: | |||
| class CustomOnValidateJson: | |||
| def enter( | |||
| def on_enter( | |||
There was a problem hiding this comment.
None of these were getting called 😢. In my opinion, this is a strong argument for using a single method with a context manager instead of multiple optional callbacks.
adriangb
added
relnotes-change
|
please review |
Deploying with
|
| Latest commit: |
8f84795
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7fa7231c.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://plugin-on-exception.pydantic-docs2.pages.dev |
samuelcolvin
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selected Reviewer: @Kludex