Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only compare pydantic fields in BaseModel.__eq__ instead of whole __dict__ #7825

Merged
merged 14 commits into from Nov 17, 2023
Merged

Only compare pydantic fields in BaseModel.__eq__ instead of whole __dict__ #7825

merged 14 commits into from Nov 17, 2023

Commits on Nov 15, 2023

  1. Added failing test case

    @QuentinSoubeyranAqemia
    QuentinSoubeyranAqemia committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    93ff605 View commit details
    Browse the repository at this point in the history

  2. fix pydantic#7444 with implementation benchmark

    @QuentinSoubeyranAqemia
    QuentinSoubeyranAqemia committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    e863614 View commit details
    Browse the repository at this point in the history

  3. Add fast-path for common-case unequal objects

    @QuentinSoubeyranAqemia
    QuentinSoubeyranAqemia committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    5b8940c View commit details
    Browse the repository at this point in the history

  4. Update pydantic/main.py 

    Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com>
    @QuentinSoubeyranAqemia @dmontagu
    QuentinSoubeyranAqemia and dmontagu committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    8771d18 View commit details
    Browse the repository at this point in the history

  5. Update pydantic/main.py 

    Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com>
    @QuentinSoubeyranAqemia @dmontagu
    QuentinSoubeyranAqemia and dmontagu committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    7a3607d View commit details
    Browse the repository at this point in the history

  6. Update pydantic/main.py 

    Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com>
    @QuentinSoubeyranAqemia @dmontagu
    QuentinSoubeyranAqemia and dmontagu committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    828d6cc View commit details
    Browse the repository at this point in the history

  7. Update pydantic/main.py 

    Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com>
    @QuentinSoubeyranAqemia @dmontagu
    QuentinSoubeyranAqemia and dmontagu committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    b48e204 View commit details
    Browse the repository at this point in the history

  8. Update pydantic/main.py 

    Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com>
    @QuentinSoubeyranAqemia @dmontagu
    QuentinSoubeyranAqemia and dmontagu committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    4639866 View commit details
    Browse the repository at this point in the history

  9. chore: share implementation with pydantic#7786

    @QuentinSoubeyranAqemia
    QuentinSoubeyranAqemia committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    c756c1f View commit details
    Browse the repository at this point in the history

  10. test: fix test incorrectly checking for hash collision avoidance

    @QuentinSoubeyranAqemia
    QuentinSoubeyranAqemia committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    e512b4b View commit details
    Browse the repository at this point in the history

  11. chore: clarify language for sentinel special typing construct

    @QuentinSoubeyranAqemia
    QuentinSoubeyranAqemia committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    dc5feb7 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. chore: simplify SafeGetItemProxy implementation

    @QuentinSoubeyranAqemia
    QuentinSoubeyranAqemia committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    63767fc View commit details
    Browse the repository at this point in the history

  2. fix: SafeGetItemProxy only accept str keys

    @QuentinSoubeyranAqemia
    QuentinSoubeyranAqemia committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    2bac43e View commit details
    Browse the repository at this point in the history

  3. chore: format

    @QuentinSoubeyranAqemia
    QuentinSoubeyranAqemia committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    d8f481b View commit details
    Browse the repository at this point in the history