Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding test for raising ValidationError with bool input and coerce_numbers_to_str=True #7826

Merged
merged 3 commits into from Oct 16, 2023
Merged

Adding test for raising ValidationError with bool input and coerce_numbers_to_str=True #7826

merged 3 commits into from Oct 16, 2023

Conversation

sydney-runkle
Copy link
Member

Change Summary

Adding test for changes made in pydantic/pydantic-core#1017

Related issue number

Adding test for #7820

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@cloudflare-pages
Copy link

cloudflare-pages bot commented Oct 14, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 36b9e7c
Status: ✅  Deploy successful!
Preview URL: https://bba9256a.pydantic-docs2.pages.dev
Branch Preview URL: https://tests-for-coerce-numbers-to.pydantic-docs2.pages.dev

View logs

@sydney-runkle sydney-runkle added relnotes-fix Used for bugfixes. relnotes-ignore Omit this PR from the release notes. and removed relnotes-fix Used for bugfixes. labels Oct 14, 2023
lig
lig approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@lig lig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Comments are just a matter of personal preference.

tests/test_types.py Show resolved Hide resolved
tests/test_types.py Outdated Show resolved Hide resolved
@sydney-runkle sydney-runkle enabled auto-merge (squash) October 16, 2023 13:16
@sydney-runkle sydney-runkle merged commit c75cecd into main Oct 16, 2023
59 checks passed
@sydney-runkle sydney-runkle deleted the tests-for-coerce-numbers-to-str-addition branch October 16, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lig lig lig approved these changes

Assignees
No one assigned
Labels
relnotes-ignore Omit this PR from the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sydney-runkle @lig