Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for unexpected_keyword_argument on dataclass #7850

Merged
merged 3 commits into from Oct 17, 2023
Merged

Add docs for unexpected_keyword_argument on dataclass #7850

merged 3 commits into from Oct 17, 2023

Conversation

laundmo
Copy link
Contributor

@laundmo laundmo commented Oct 17, 2023 •
edited by pydantic-hooky bot

Change Summary

Document that unexpected_keyword_argument also happens when using dataclasses and extras are forbidden

Related issue number

None, trivial

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @davidhewitt

@laundmo
Copy link
Contributor Author

laundmo commented Oct 17, 2023

please review

davidhewitt
davidhewitt approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

@davidhewitt davidhewitt merged commit 188018c into pydantic:main Oct 17, 2023
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees

@davidhewitt davidhewitt

Labels
documentation ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@laundmo @davidhewitt