Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pydantic dataclass problem with dataclasses.field default #7898

Merged
merged 2 commits into from Oct 23, 2023
Merged

Fix pydantic dataclass problem with dataclasses.field default #7898

merged 2 commits into from Oct 23, 2023

Conversation

hramezani
Copy link
Member

@hramezani hramezani commented Oct 23, 2023 •
edited by pydantic-hooky bot

Fixes #7895

Selected Reviewer: @dmontagu

@cloudflare-pages
Copy link

cloudflare-pages bot commented Oct 23, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bc1f1c4
Status: ✅  Deploy successful!
Preview URL: https://73d15326.pydantic-docs2.pages.dev
Branch Preview URL: https://dataclass-filed-default.pydantic-docs2.pages.dev

View logs

@hramezani hramezani added the relnotes-fix Used for bugfixes. label Oct 23, 2023
@hramezani hramezani mentioned this pull request Oct 23, 2023
Closed
1 task
@hramezani
Copy link
Member Author

Please review

PrettyWood
PrettyWood approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@PrettyWood PrettyWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

pydantic/_internal/_fields.py Outdated Show resolved Hide resolved
@hramezani hramezani enabled auto-merge (squash) October 23, 2023 11:21
@hramezani hramezani merged commit d044f39 into main Oct 23, 2023
58 checks passed
@hramezani hramezani deleted the dataclass_filed_default branch October 23, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrettyWood PrettyWood PrettyWood approved these changes

Assignees

@dmontagu dmontagu

Labels
ready for review relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent model_dump behavior with dataclasses and field(init=False)
3 participants
@hramezani @PrettyWood @dmontagu