Fix schema generation for generics with union type bounds #7899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review |
davidhewitt
approved these changes
Oct 23, 2023
| @@ -1508,6 +1508,22 @@ class MyInt(int): | |||
| ReferenceModel[MyInt] | |||
|
|
|||
|
|
|||
| def test_generic_with_referenced_generic_union_type_bound(): | |||
| T = TypeVar('T', bound=Union[str, int]) | |||
There was a problem hiding this comment.
From typing docs there is an example of a union bound, so I think it is completely correct to test this case 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix schema generation for generics with union type bounds
Related issue number
Initially reported as part of a thread in #7884
Checklist
Selected Reviewer: @hramezani