Add support for `NotRequired` generics in `TypedDict` #7932

sydney-runkle · 2023-10-26T01:59:03Z

Change Summary

Add support for NotRequired generics in TypedDict

The pull request title is a good summary of the changes - it will be used in the changelog
Unit tests for the changes exist
Tests pass on CI
Documentation reflects the changes where applicable
My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

cloudflare-pages · 2023-10-26T02:00:54Z

Latest commit:	`257ddd6`
Status:	✅ Deploy successful!
Preview URL:	https://2b106fcc.pydantic-docs2.pages.dev
Branch Preview URL:	https://fix-tuple-handling-for-gener.pydantic-docs2.pages.dev

sydney-runkle · 2023-10-26T02:13:51Z

Please review

tests/test_generics.py

pydantic/_internal/_generics.py

fix for generics with not required in typed dict

17fd1f9

sydney-runkle added the relnotes-fix Used for bugfixes. label Oct 26, 2023

pydantic-hooky bot added the ready for review label Oct 26, 2023

pydantic-hooky bot assigned adriangb Oct 26, 2023

lig reviewed Oct 26, 2023

View reviewed changes

tests/test_generics.py Outdated Show resolved Hide resolved

pydantic/_internal/_generics.py Show resolved Hide resolved

lig approved these changes Oct 26, 2023

View reviewed changes

adding clarifying comment and improving test

257ddd6

sydney-runkle enabled auto-merge (squash) October 26, 2023 14:05

sydney-runkle merged commit 064b24c into main Oct 26, 2023
59 checks passed

sydney-runkle deleted the fix-tuple-handling-for-generic-types branch October 26, 2023 14:18