Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for union serialization fix #7959

Merged
merged 3 commits into from Oct 30, 2023
Merged

Add tests for union serialization fix #7959

merged 3 commits into from Oct 30, 2023

Conversation

sydney-runkle
Copy link
Member

@sydney-runkle sydney-runkle commented Oct 29, 2023 •
edited by pydantic-hooky bot

Change Summary

Adding tests for union serialization fix from pydantic/pydantic-core#1039

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @lig

@sydney-runkle sydney-runkle added the relnotes-fix Used for bugfixes. label Oct 29, 2023
@cloudflare-pages
Copy link

cloudflare-pages bot commented Oct 29, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4eb4238
Status: ✅  Deploy successful!
Preview URL: https://6c9206b2.pydantic-docs2.pages.dev
Branch Preview URL: https://fix-union-issues.pydantic-docs2.pages.dev

View logs

@sydney-runkle
Copy link
Member Author

Please review

lig
lig reviewed Oct 30, 2023
View reviewed changes
tests/test_serialize.py Outdated Show resolved Hide resolved
lig
lig approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@lig lig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@sydney-runkle sydney-runkle enabled auto-merge (squash) October 30, 2023 16:51
@sydney-runkle sydney-runkle merged commit f4b0eaa into main Oct 30, 2023
58 checks passed
@sydney-runkle sydney-runkle deleted the fix-union-issues branch October 30, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lig lig lig approved these changes

Assignees

@lig lig

Labels
ready for review relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sydney-runkle @lig