Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plurals in validation error messages (in tests) #7972

Merged
merged 2 commits into from Nov 3, 2023

Conversation

Iipin
Copy link
Contributor

@Iipin Iipin commented Oct 30, 2023

Change Summary

A complementary change to pydantic/pydantic-core#1050 – adjust grammar in error message assertions.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks great overall. Thanks for your contribution!

Could you add a pytest.mark.xfail marker on all of the tests that you changed similar to this:

@pytest.mark.xfail(reason='Needs new release of pydantic-core')

We can remove this once we release a new version of pydantic-core with your changes :)

@sydney-runkle sydney-runkle added the relnotes-fix Used for bugfixes. label Nov 3, 2023
@sydney-runkle sydney-runkle changed the title fix(tests): adjust assertions with plurals in validation error messages Fix plurals in validation error messages (in tests) Nov 3, 2023
@Iipin
Copy link
Contributor Author

Iipin commented Nov 3, 2023

@sydney-runkle thank you for the comment – marked failing tests, ptal. I see that pypy3.9 has segfaulted in CI but I don't think this has anything to do with my change so I'm marking the PR as ready :)

Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome :), thanks for the contribution!

@sydney-runkle sydney-runkle enabled auto-merge (squash) November 3, 2023 18:22
@sydney-runkle sydney-runkle merged commit 0a2377e into pydantic:main Nov 3, 2023
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants