Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearer error on invalid Plugin #8023

Merged
merged 3 commits into from Nov 6, 2023
Merged

Clearer error on invalid Plugin #8023

merged 3 commits into from Nov 6, 2023

Conversation

samuelcolvin
Copy link
Member

I got an error from a residual example_plugin install, seemed useful to give more details on the plugin that causes the error.

@samuelcolvin samuelcolvin enabled auto-merge (squash) November 6, 2023 14:49
Copy link

cloudflare-pages bot commented Nov 6, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8734f18
Status: ✅  Deploy successful!
Preview URL: https://125c9f40.pydantic-docs2.pages.dev
Branch Preview URL: https://plugin-error-details.pydantic-docs2.pages.dev

View logs

@sydney-runkle sydney-runkle added the relnotes-fix Used for bugfixes. label Nov 6, 2023
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, I pulled in the main branch as well so we could get tests passing 👍

@samuelcolvin samuelcolvin merged commit cde3779 into main Nov 6, 2023
59 checks passed
@samuelcolvin samuelcolvin deleted the plugin-error-details branch November 6, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants