Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct pydantic dataclasses import #8027

Merged
merged 3 commits into from Nov 6, 2023
Merged

Conversation

samuelcolvin
Copy link
Member

Fix #8020.

Thanks so much @alexmojaki for catching this one, could have been quite bad if it had been released!

Copy link

cloudflare-pages bot commented Nov 6, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 72c5138
Status:🚫  Deploy failed.

View logs

@sydney-runkle sydney-runkle added the relnotes-fix Used for bugfixes. label Nov 6, 2023
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sydney-runkle sydney-runkle mentioned this pull request Nov 6, 2023
10 tasks
@samuelcolvin samuelcolvin enabled auto-merge (squash) November 6, 2023 19:03
@samuelcolvin samuelcolvin merged commit e01cad6 into main Nov 6, 2023
57 of 58 checks passed
@samuelcolvin samuelcolvin deleted the fix-dataclass-import branch November 6, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using pydantic.dataclasses after only importing pydantic gives the stdlib dataclasses module
3 participants