Allow str as argument to Discriminator
#8047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmontagu
commented
Nov 7, 2023
Comment on lines
+133
to
+143
| @pytest.mark.parametrize('color_discriminator_kind', ['discriminator', 'field_str', 'field_discriminator']) | ||
| @pytest.mark.parametrize('pet_discriminator_kind', ['discriminator', 'field_str', 'field_discriminator']) | ||
| def test_discriminated_union_validation(color_discriminator_kind, pet_discriminator_kind): | ||
| def _get_str_discriminator(discriminator: str, kind: str): | ||
| if kind == 'discriminator': | ||
| return Discriminator(discriminator) | ||
| elif kind == 'field_str': | ||
| return Field(discriminator=discriminator) | ||
| elif kind == 'field_discriminator': | ||
| return Field(discriminator=Discriminator(discriminator)) | ||
| raise ValueError(f'Invalid kind: {kind}') |
There was a problem hiding this comment.
I feel that this is a fairly thorough test that all the ways to possibly use a str as a discriminator, even together, are working as expected. 🤞
Deploying with
|
| Latest commit: |
235c3ac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://20cb0889.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://allow-str-discriminator.pydantic-docs2.pages.dev |
sydney-runkle
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Also renamed
CallableDiscriminatortoDiscriminator.)As discussed @sydney-runkle