Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update union documentation for reimplemented "smart" mode #8070

Merged
merged 4 commits into from Nov 9, 2023

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Updates the union documentation to describe the new "smart" mode following the rework in core.

Related issue number

pydantic/pydantic-core#867

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

cloudflare-pages bot commented Nov 9, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 844babe
Status: ✅  Deploy successful!
Preview URL: https://2b3856e2.pydantic-docs2.pages.dev
Branch Preview URL: https://dh-union-mode-docs.pydantic-docs2.pages.dev

View logs

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM.

docs/concepts/unions.md Outdated Show resolved Hide resolved
docs/concepts/unions.md Outdated Show resolved Hide resolved
docs/concepts/unions.md Outdated Show resolved Hide resolved
docs/concepts/unions.md Outdated Show resolved Hide resolved
docs/concepts/unions.md Show resolved Hide resolved
docs/concepts/unions.md Outdated Show resolved Hide resolved
davidhewitt and others added 2 commits November 9, 2023 15:02
Co-authored-by: Samuel Colvin <s@muelcolvin.com>
Co-authored-by: Sydney Runkle <54324534+sydney-runkle@users.noreply.github.com>
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the quick update.

@davidhewitt davidhewitt enabled auto-merge (squash) November 9, 2023 15:34
@davidhewitt davidhewitt merged commit 41f1dc3 into main Nov 9, 2023
59 checks passed
@davidhewitt davidhewitt deleted the dh/union-mode-docs branch November 9, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants