Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to pyright==1.1.335 #8075

Merged
merged 2 commits into from Nov 11, 2023
Merged

Update to pyright==1.1.335 #8075

merged 2 commits into from Nov 11, 2023

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Nov 10, 2023 •
edited by pydantic-hooky bot

Change Summary

Had to fetch new typeshed changes in #6563, and some unrelated errors got catched by latest pyright.

Not really satisfied with issues with Self (ideally return types should be Self | FieldInfo, but well..)

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @sydney-runkle

@Viicos
Copy link
Contributor Author

Viicos commented Nov 10, 2023

Please review

sydney-runkle
sydney-runkle approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Viicos for all of your help this week 🌟

@sydney-runkle sydney-runkle added the relnotes-packaging Used for dependency changes. label Nov 10, 2023
dmontagu
dmontagu reviewed Nov 10, 2023
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@sydney-runkle sydney-runkle merged commit 2358e63 into pydantic:main Nov 11, 2023
59 checks passed
@Viicos Viicos deleted the update-pyright branch November 11, 2023 13:07
@sydney-runkle sydney-runkle mentioned this pull request Nov 27, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmontagu dmontagu dmontagu left review comments

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees

@sydney-runkle sydney-runkle

Labels
ready for review relnotes-packaging Used for dependency changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Viicos @dmontagu @sydney-runkle