Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'ValidateCallWrapper' error when creating a model which has a @validate_call wrapped field annotation. #8110

Merged
merged 3 commits into from Nov 14, 2023

Conversation

sydney-runkle
Copy link
Member

@sydney-runkle sydney-runkle commented Nov 14, 2023

Change Summary

Minor fixes to be included in 2.5.1 patch release

Related issue number

Fix #8094
Fix #8095

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@sydney-runkle sydney-runkle added the relnotes-fix Used for bugfixes. label Nov 14, 2023
@sydney-runkle sydney-runkle self-assigned this Nov 14, 2023
Copy link

cloudflare-pages bot commented Nov 14, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c2f8ae8
Status: ✅  Deploy successful!
Preview URL: https://a61a926e.pydantic-docs2.pages.dev
Branch Preview URL: https://2-5.pydantic-docs2.pages.dev

View logs

Copy link

codspeed-hq bot commented Nov 14, 2023

CodSpeed Performance Report

Merging #8110 will not alter performance

Comparing 2.5 (c2f8ae8) with main (0564c0d)

Summary

✅ 10 untouched benchmarks

@sydney-runkle sydney-runkle marked this pull request as ready for review November 14, 2023 14:40
@sydney-runkle sydney-runkle changed the title 2.5.0 Fixes Fixes to add to 2.5.1 Nov 14, 2023
@sydney-runkle sydney-runkle removed their assignment Nov 14, 2023
@sydney-runkle sydney-runkle enabled auto-merge (squash) November 14, 2023 14:46
@sydney-runkle sydney-runkle merged commit e5e47d8 into main Nov 14, 2023
53 checks passed
sydney-runkle added a commit that referenced this pull request Nov 14, 2023
hramezani pushed a commit that referenced this pull request Nov 15, 2023
@hramezani hramezani changed the title Fixes to add to 2.5.1 Fix 'ValidateCallWrapper' error when creating a model which has a @validate_call wrapped field annotation. Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
2 participants