Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about email-validator in migration guide #8200

Merged
merged 1 commit into from Nov 22, 2023

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Nov 22, 2023

Change Summary

Fixes #8196. Having #6033 would be nice as well.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

codspeed-hq bot commented Nov 22, 2023

CodSpeed Performance Report

Merging #8200 will not alter performance

Comparing Viicos:patch-2 (d5792b5) with main (64ce5b9)

Summary

✅ 10 untouched benchmarks

@sydney-runkle sydney-runkle added the relnotes-ignore Omit this PR from the release notes. label Nov 22, 2023
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Viicos

@sydney-runkle sydney-runkle merged commit 9ab33eb into pydantic:main Nov 22, 2023
54 of 55 checks passed
@Viicos Viicos deleted the patch-2 branch November 22, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-ignore Omit this PR from the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Depending on email-validator>=2 is backwards incompatible
2 participants