Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eval_type_backport to handle union operator and builtin generic subscripting in older Pythons #8209
Add eval_type_backport to handle union operator and builtin generic subscripting in older Pythons #8209
Changes from 16 commits
75986a9
ca60caa
a163ea3
8033556
0495f0f
780b46a
4c536b6
d7f874b
09d2e93
d7b1462
c65ae3d
3aa88da
ca09a03
4890fc8
c2d9d22
40a41fb
7da17e0
a998d14
4f465a3
71ca7cf
f060876
2b42d65
dcbdd28
959c755
71c912e
9847058
6beab5b
b79692b
6bc0ee4
f423659
d3d5584
aa21092
8da4294
60aa70f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't we need this anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT this could always have been replaced with
typing._eval_type
. Now it has to be, with the backport.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to change most tests, just add some new tests specifically for the new behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reverted the random test changes, updated existing tests more strategically where it seemed natural (i.e. they already used
from __future__ import annotations
or they were skipped for Python <= 3.9), and added new tests in various files (all calledtest_eval_type_backport
) to test the different places whereeval_type_backport
is called.