Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for namespace issue with dataclasses with from __future__ import annotations #8513

Merged
merged 2 commits into from Jan 8, 2024
+4 −0
Merged

fix for namespace issue with dataclasses with from __future__ import annotations #8513

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe4b809
fix for namespace issue with from __future__ import annotations
sydney-runkle Jan 8, 2024
b68e7e3
fix typecheck error
sydney-runkle Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions pydantic/_internal/_fields.py
View file
Open in desktop
Expand Up @@ -264,6 +264,10 @@ def collect_dataclass_fields(
dataclass_fields: dict[str, dataclasses.Field] = cls.__dataclass_fields__
cls_localns = dict(vars(cls)) # this matches get_cls_type_hints_lenient, but all tests pass with `= None` instead

source_module = sys.modules.get(cls.__module__)
if source_module is not None:
types_namespace = {**source_module.__dict__, **(types_namespace or {})}

for ann_name, dataclass_field in dataclass_fields.items():
ann_type = _typing_extra.eval_type_lenient(dataclass_field.type, types_namespace, cls_localns)
if is_classvar(ann_type):
Expand Down