New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix strict parsing for some Sequence
s
#8614
Conversation
Deploying with Cloudflare Pages
|
CodSpeed Performance ReportMerging #8614 will not alter performanceComparing Summary
|
if value_type == tuple: | ||
__input_value = list(__input_value) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is certainly not the most performant, but we already warn about the performance consequences of using Sequence[X]
in the docs, so I'm ok with this change for now, assuming we implement the refactor for sequence validators in the future.
Please review |
Change Summary
Handle this case properly, right now, it errors:
Related issue number
Fix #8604
Checklist
Selected Reviewer: @lig