Fix test failures with pytest-8.0.0 due to pytest.warns() starting to work inside pytest.raises()
#8678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `tests/test_validators.py::test_use_no_fields` not to check for a warning that can't be emitted because calling the decorator fails with a `TypeError`. Starting with pytest 8.0.0 (due to pytest-dev/pytest#9036 fix), `pytest.warns()` assertions are enforced even if an exception is raised and consumed by `pytest.raises()`. Bug pydantic#8674
Emit Pydantic V1 style `@validator` deprecation warnings before raising `PydanticUserError` about incorrect use. This is one of the possible solutions to test failures introduced with pytest 8.0.0, as now `pytest.warns()` assertions are enforced even if an exception raised and caught by `pytest.raises()` (this is pytest-dev/pytest#9036). The alternate possibility would be to remove `pytest.warns()` from respective test functions but I think it's reasonable to emit these warnings, to warn the users that they ought to consider upgrading the code to Pydantic V2 API rather than fixing the immediate issue. Bug pydantic#8674
CodSpeed Performance ReportMerging #8678 will not alter performanceComparing Summary
|
|
please review |
|
Marking this as fixing the issue that you've filed, and we can open a new one when the time comes! |
sydney-runkle
approved these changes
Feb 6, 2024
|
Thanks!
Should I open another issue for the remaining test failures? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix the test suite problems that cause test failures with pytest-8.0.0, due to
pytest.warns()being fixed to work insidepytest.raises().I've specifically:
pytest.warns()when no warning could be produced because of invalid function call raisingTypeError.pytest.warns()assertion instead.This doesn't fix all the test failures reported in the linked bug, though.
test_validator_bad_fields_throws_configerrorfails due to changed exception representation, and I don't know how to clearly handle both versions.Additionally,
test_root_validator_allow_reuse_same_fieldfails with the default-Werror(I didn't include that in the bug), sincepytest.warns()passes the warning through. However, adding a secondpytest.warns()to check for that breaks the test with older pytest versions, where the warning is captured by the otherpytest.warns().Related issue number
Fix #8674
Checklist
Selected Reviewer: @hramezani