Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo and broken link in TypeAdapter description in "Why" docs #8703

Merged
merged 1 commit into from Feb 2, 2024

Conversation

ADSteele916
Copy link
Contributor

@ADSteele916 ADSteele916 commented Feb 2, 2024

Change Summary

I changed the misspelled NampedTuple to NamedTuple and updated its hyperlink, which appears to have been accidentally broken by #7417.

Related issue number

The PR template says that an issue is only required for non-trivial changes. If need be, I can create one for this PR to track.

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @samuelcolvin

Copy link

codspeed-hq bot commented Feb 2, 2024

CodSpeed Performance Report

Merging #8703 will not alter performance

Comparing ADSteele916:fix-why-docs-typeadapter (8b51aa8) with main (8898b8f)

Summary

✅ 10 untouched benchmarks

@ADSteele916
Copy link
Contributor Author

My apologies; I don't seem to have permission to add a documentation label. Could a maintainer please review when possible?

@sydney-runkle sydney-runkle added the relnotes-ignore Omit this PR from the release notes. label Feb 2, 2024
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks!!

@sydney-runkle sydney-runkle merged commit fbed014 into pydantic:main Feb 2, 2024
53 of 55 checks passed
@ADSteele916 ADSteele916 deleted the fix-why-docs-typeadapter branch February 2, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review relnotes-ignore Omit this PR from the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants