Allow an optional separator splitting the value and unit of the result of ByteSize.human_readable.

[jks15satoshi]

Change Summary

Allow splitting the value and unit of the result of ByteSize.human_readable with a separator providing by the argument separator.

>>> size = ByteSize(12345678)
>>> size.human_readable()
'11.8MiB'
>>> size.human_readable(separator=' ')
'11.8 MiB'

Related issue number

fix #8668

Checklist

• The pull request title is a good summary of the changes - it will be used in the changelog
• Unit tests for the changes exist
• Tests pass on CI
• Documentation reflects the changes where applicable
• My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

[codspeed-hq]

CodSpeed Performance Report

Merging #8706 will not alter performance

_{Comparing jks15satoshi:main (c3c007c) with main (8898b8f)}

Summary

✅ 10 untouched benchmarks

[jks15satoshi]

Please review

[sydney-runkle]

@jks15satoshi,

I think it'd make more sense to support a str type separator, which is an empty string by default. Could you please use that approach instead?

Thanks for your work here. Looking forward to having this new feature.

[jks15satoshi]

@jks15satoshi,

I think it'd make more sense to support a str type separator, which is an empty string by default. Could you please use that approach instead?

Thanks for your work here. Looking forward to having this new feature.

OK. Changes committed.

[sydney-runkle]

Looks great, thanks! So excited to have this as a new feature in our upcoming minor release :).

[jks15satoshi]

Looks great, thanks! So excited to have this as a new feature in our upcoming minor release :).

Thanks so much! It's my pleasure.