Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default inclusion in FieldInfo.__repr_args__ #8801

Merged
merged 2 commits into from Feb 13, 2024

Conversation

sydney-runkle
Copy link
Member

@sydney-runkle sydney-runkle commented Feb 13, 2024

Fix #8629

Make sure that when default=None is set, this is reflected when you print out FieldInfo instances.

Selected Reviewer: @Kludex

@sydney-runkle sydney-runkle added the relnotes-fix Used for bugfixes. label Feb 13, 2024
@sydney-runkle
Copy link
Member Author

Please review

Copy link

cloudflare-pages bot commented Feb 13, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4ab922f
Status: ✅  Deploy successful!
Preview URL: https://e15fd03c.pydantic-docs2.pages.dev
Branch Preview URL: https://fix-repr-args-for-fields.pydantic-docs2.pages.dev

View logs

Copy link

codspeed-hq bot commented Feb 13, 2024

CodSpeed Performance Report

Merging #8801 will not alter performance

Comparing fix-repr-args-for-fields (4ab922f) with main (14ce997)

Summary

✅ 10 untouched benchmarks

@sydney-runkle sydney-runkle enabled auto-merge (squash) February 13, 2024 16:15
@sydney-runkle sydney-runkle merged commit 332eac4 into main Feb 13, 2024
53 checks passed
@sydney-runkle sydney-runkle deleted the fix-repr-args-for-fields branch February 13, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FieldInfo.__repr_args__ ignoring field's default value when set to None explicitly
3 participants