Add better error message for improper definition of RootModel with Generic #8804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
somehow I'm having these errors and I don't know how to proceed /pydantic/pydantic/_internal/_model_construction.py
/pydantic/pydantic/_internal/_model_construction.py:188:21 - error: Cannot assign member "__pydantic_generic_metadata__" for type "type[RootModel[Unknown]]"
Expression of type "dict[str, Unknown]" cannot be assigned to member "__pydantic_generic_metadata__" of class "RootModel[Unknown]"
Member "__set__" is unknown
"dict[str, Unknown]" is incompatible with "PydanticGenericMetadata" (reportGeneralTypeIssues)
/pydantic/pydantic/_internal/_model_construction.py:188:21 - error: Cannot assign member "__pydantic_generic_metadata__" for type "type[BaseModel]"
Expression of type "dict[str, Unknown]" cannot be assigned to member "__pydantic_generic_metadata__" of class "BaseModel"
Member "__set__" is unknown
"dict[str, Unknown]" is incompatible with "PydanticGenericMetadata" (reportGeneralTypeIssues)
2 errors, 0 warnings, 0 informations |
1 task
Massakera
changed the title
sydney-runkle
requested changes
Feb 13, 2024
There was a problem hiding this comment.
A few notes:
- There was a lot of reformatting done that I don't think is necessary - you can probably revert these changes with
make format, and fix the linting errors as well. That should make the diff a lot smaller - Please add a test to showcase the new behavior
- You'll want to dedent the call to
raise TypeError(error_message)to make sure that it's raised in any of the 3 cases being handled
sydney-runkle
added
the
relnotes-change
sydney-runkle
changed the title
|
Closing in favor of #8857. Thanks for the good start on this work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This PR add a new error message when creating a generic RootModel without providing the generic to the model in the class inheritance. Now, it mention the needed parametrization of the RootModel itself
Related issue number
fix #8712
Checklist