Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining type hinting suggestions #8805

Merged
merged 5 commits into from Feb 13, 2024
Merged

Remaining type hinting suggestions #8805

merged 5 commits into from Feb 13, 2024

Conversation

sydney-runkle
Copy link
Member

@sydney-runkle sydney-runkle commented Feb 13, 2024

Adding remaining suggestions from #7680

Selected Reviewer: @alexmojaki

@sydney-runkle sydney-runkle added the relnotes-ignore Omit this PR from the release notes. label Feb 13, 2024
@sydney-runkle
Copy link
Member Author

Please review

Copy link

cloudflare-pages bot commented Feb 13, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0765da6
Status: ✅  Deploy successful!
Preview URL: https://742a0f00.pydantic-docs2.pages.dev
Branch Preview URL: https://fix-alex-suggestions.pydantic-docs2.pages.dev

View logs

Co-authored-by: Alex Hall <alex.mojaki@gmail.com>
pydantic/main.py Outdated Show resolved Hide resolved
Copy link

codspeed-hq bot commented Feb 13, 2024

CodSpeed Performance Report

Merging #8805 will not alter performance

Comparing fix-alex-suggestions (0765da6) with main (3d1355f)

Summary

✅ 10 untouched benchmarks

@alexmojaki
Copy link
Contributor

Thanks!

@sydney-runkle sydney-runkle enabled auto-merge (squash) February 13, 2024 19:07
@sydney-runkle sydney-runkle merged commit 071c2c8 into main Feb 13, 2024
53 checks passed
@sydney-runkle sydney-runkle deleted the fix-alex-suggestions branch February 13, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review relnotes-ignore Omit this PR from the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants