Fix usage of AliasGenerator with computed_field decorator
#8806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dantic into fix-alex-suggestions
Deploying with
|
| Latest commit: |
ef959d9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://82e9754c.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://alias-gen-fixes.pydantic-docs2.pages.dev |
|
Please review |
CodSpeed Performance ReportMerging #8806 will not alter performanceComparing Summary
|
dmontagu
reviewed
Feb 13, 2024
dmontagu
reviewed
Feb 13, 2024
dmontagu
reviewed
Feb 13, 2024
| # note that we use the serialization_alias with priority over alias, as computed_field | ||
| # aliases are used for serialization only (not validation) | ||
| if computed_field_info.alias_priority == 1: | ||
| computed_field_info.alias = serialization_alias or alias |
There was a problem hiding this comment.
I would do
Suggested change
| computed_field_info.alias = serialization_alias or alias | |
| computed_field_info.alias = serialization_alias if serialization_alias is not None else alias |
to handle the case of serialization_alias = '' and alias != ''. Probably worth a comment about why, though not a test.
I could be convinced not to do that but I do think there are tests for the alias = '' case elsewhere in the codebase.
There was a problem hiding this comment.
I think we should do this, but in a different PR, to both the field_info logic and the computed_field_info logic.
There was a problem hiding this comment.
Also, doesn't seem like an urgent change 👍
dmontagu
approved these changes
Feb 13, 2024
sydney-runkle
added a commit
that referenced
this pull request
Mar 8, 2024
Co-authored-by: Alex Hall <alex.mojaki@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8768
Ensure that
AliasGeneratoris handled properly when using it along with acomputed_fieldin a model.Selected Reviewer: @samuelcolvin