New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct docs, logic for model_construct
behavior with extra
#8807
Conversation
Deploying with Cloudflare Pages
|
CodSpeed Performance ReportMerging #8807 will not alter performanceComparing Summary
|
Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense, but like you say it is technically a breaking change. Is there a strong justification to make this change?
I think it's a minor enough breaking change that we can include it in a minor release, and I'd rather have strong documentation + correct behavior sooner rather than later. The sooner we fix this, the fewer people a change would impact down the line. But other than one person reporting the inconsistency in the docs / behavior, there's no strong justification. |
I think the fact that the runtime behavior is different than the documented behavior is a good start to justify the change. |
Fix #8266
model_construct
behavior based on a model'sextra
settingmodel_config.extra == 'ignore'
Selected Reviewer: @adriangb