Fix: allow empty string aliases with AliasGenerator
#8810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review |
Deploying with
|
| Latest commit: |
158a2bc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c9f31cc9.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://alias-gen-str-fixes.pydantic-docs2.pages.dev |
CodSpeed Performance ReportMerging #8810 will not alter performanceComparing Summary
|
dmontagu
approved these changes
Feb 15, 2024
| @@ -296,6 +296,15 @@ def push(self, for_type: type[Any]): | |||
| self._types_namespace_stack.pop() | |||
|
|
|||
|
|
|||
| def _get_first_non_null(a: Any, b: Any) -> Any: | |||
There was a problem hiding this comment.
Suggested change
| def _get_first_non_null(a: Any, b: Any) -> Any: | |
| def _get_first_not_none(a: Any, b: Any) -> Any: |
not a big deal.
There was a problem hiding this comment.
For what it's worth, I don't think it would be crazy to just copy the if <a> is not None else everywhere, but I'm okay with this too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8808
Selected Reviewer: @dmontagu