Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to company announcement in README #8847

Merged
merged 1 commit into from Feb 19, 2024
Merged

Conversation

adamency
Copy link
Contributor

Change Summary

The link in the readme about the company announcement is actually simply a link to the blog/announcement page of pydantic's website, and it is not immediately clear that this isn't a broken link, added to the fact that people have to search for the actual page that was referred to. This PR modifies it to point directly to the actual announcement.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

codspeed-hq bot commented Feb 19, 2024

CodSpeed Performance Report

Merging #8847 will not alter performance

Comparing adamency:main (b777d62) with main (12ebdfc)

Summary

✅ 10 untouched benchmarks

@adamency
Copy link
Contributor Author

adamency commented Feb 19, 2024

The release notes test fails, but this PR shouldn't have have any release note as it is a trivial readme change. Should I do something about it ?

@hramezani hramezani added the relnotes-ignore Omit this PR from the release notes. label Feb 19, 2024
@hramezani
Copy link
Member

Thanks @adamency

@hramezani hramezani enabled auto-merge (squash) February 19, 2024 10:19
@hramezani hramezani merged commit 9baad29 into pydantic:main Feb 19, 2024
52 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-ignore Omit this PR from the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants