Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize pyproject.toml sections #8899

Merged
merged 1 commit into from Feb 27, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Feb 27, 2024

As per #8237.

the project table wasn't set at the top of file, which would make pdm move it around in the file each time a pdm command was run.

Added packaging as a dev dependency. It is used in #8237 but added here to avoid conflicts (packaging is already implicitly included in the lock file so test passes in #8237, this is just to make it explicit here)

Add `packaging` as a `testing` dev dependency
Copy link

codspeed-hq bot commented Feb 27, 2024

CodSpeed Performance Report

Merging #8899 will not alter performance

Comparing Viicos:reorganize-pyproject (47dfd31) with main (9811727)

Summary

✅ 10 untouched benchmarks

@sydney-runkle sydney-runkle added the relnotes-packaging Used for dependency changes. label Feb 27, 2024
@sydney-runkle
Copy link
Member

Changes look great. Thanks!

@sydney-runkle sydney-runkle merged commit 752daaf into pydantic:main Feb 27, 2024
53 of 54 checks passed
@Viicos Viicos deleted the reorganize-pyproject branch February 27, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-packaging Used for dependency changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants