New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add information about class in error message of schema generation #8917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Could you please add a test?
CodSpeed Performance ReportMerging #8917 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few quick notes. Looks good, assuming you fix the linting errors as well. Thanks a bunch!
Co-authored-by: Sydney Runkle <54324534+sydney-runkle@users.noreply.github.com>
You should be able to run |
I think that I have done it. |
Looks like you fixed the linting, but your test is failing |
I see, but your workflow is totally different from this one that I’m familiar with, and it takes me longer time to identify how to test things locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Thanks!!
Change Summary
Finally, the last of my dependency reached pydantic 2 compatibility, so I could start migrating my package. I meet an error that requires using a debugger to understand where is a problem as I cannot find which class is responsible for the problem. In this PR I add information about class that have
__modify_schema__
and do not have__get_pydantic_json_schema__
Related issue number
Checklist