Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More helpful error re wrong model_json_schema usage #8928

Merged
merged 2 commits into from Mar 1, 2024
Merged

More helpful error re wrong model_json_schema usage #8928

merged 2 commits into from Mar 1, 2024

Conversation

sydney-runkle
Copy link
Member

@sydney-runkle sydney-runkle commented Mar 1, 2024 •
edited by pydantic-hooky bot

Fix #8896

Selected Reviewer: @davidhewitt

@sydney-runkle
Copy link
Member Author

Please review

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 1, 2024 •
edited

CodSpeed Performance Report

Merging #8928 will not alter performance

Comparing json-schema-helpful-error (1794dcd) with main (db0f809)

Summary

✅ 10 untouched benchmarks

dmontagu
dmontagu reviewed Mar 1, 2024
View reviewed changes
pydantic/json_schema.py Outdated Show resolved Hide resolved
@sydney-runkle @dmontagu
Change error message
1794dcd 
Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com>
@sydney-runkle sydney-runkle added the relnotes-fix Used for bugfixes. label Mar 1, 2024
@sydney-runkle sydney-runkle merged commit e1a5c18 into main Mar 1, 2024
54 of 55 checks passed
@sydney-runkle sydney-runkle deleted the json-schema-helpful-error branch March 1, 2024 15:50
@Viicos Viicos mentioned this pull request Mar 12, 2024
Closed
1 task
@Viicos Viicos mentioned this pull request Apr 16, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmontagu dmontagu dmontagu approved these changes

Assignees

@davidhewitt davidhewitt

Labels
ready for review relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AssertionError when calling BaseModel.schema_json()
3 participants
@sydney-runkle @dmontagu @davidhewitt