New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow field_serializer('*') (fix #8990) #9001
Conversation
CodSpeed Performance ReportMerging #9001 will not alter performanceComparing Summary
|
please review @sydney-runkle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a bit of feedback. Thanks for your work on this :). And thanks for the tests!
Co-authored-by: Sydney Runkle <54324534+sydney-runkle@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, but please fix the linting errors before we merge!
fixed linting
turns out the initial doc change was correct 😄 |
Hmm, I don't think it was -- I think you just needed to fix the whitespace... could you try that instead? |
here's to hoping i checked everything properly this time! sorry for the trouble |
No worries at all. Looks great, thanks so much :). |
Change Summary
allow
field_serializer('*')
for defining a serializer for all fields in a modelRelated issue number
fix #8990
Checklist
Selected Reviewer: @davidhewitt