New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support re.Pattern[str]
to pattern
field
#9053
Conversation
CodSpeed Performance ReportMerging #9053 will not alter performanceComparing Summary
|
please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, would be helpful to add some tests! Thanks!
@jag-k, ping! |
ba6a845
to
1e06ec3
Compare
1e06ec3
to
6e96b8d
Compare
@sydney-runkle Sorry to keep you waiting. I missed your message a bit in the mail. I added tests. Tell me, is everything okay with them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for your work on this!
Change Summary
I think it just a simple idea about using already compiled regexp to set in
pattern
field.Example:
Related issue number
fix #9052
Checklist
Selected Reviewer: @davidhewitt