Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clickhouse-dsn #9062

Merged
merged 2 commits into from Mar 21, 2024
Merged

clickhouse-dsn #9062

merged 2 commits into from Mar 21, 2024

Conversation

solidguy7
Copy link
Contributor

@solidguy7 solidguy7 commented Mar 20, 2024 •
edited

ClickhouseDsn

Just added dsn for Clickhouse

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 20, 2024 •
edited

CodSpeed Performance Report

Merging #9062 will not alter performance

Comparing solidguy7:clickhouse-dsn (be315e8) with main (a3b7214)

Summary

✅ 10 untouched benchmarks

sydney-runkle
sydney-runkle requested changes Mar 21, 2024
View reviewed changes
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks!

pydantic/__init__.py Outdated
@@ -124,6 +124,7 @@
'NatsDsn',
'MySQLDsn',
'MariaDBDsn',
'ClickhouseDsn',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be ClickHouseDsn...

sydney-runkle
sydney-runkle approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!!

@sydney-runkle sydney-runkle enabled auto-merge (squash) March 21, 2024 16:20
@sydney-runkle sydney-runkle merged commit 99147ca into pydantic:main Mar 21, 2024
52 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees

@solidguy7 solidguy7

Labels
awaiting author revision relnotes-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@solidguy7 @sydney-runkle