Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ClassVar forward ref inherited from parent class #9097

Merged
merged 2 commits into from Mar 25, 2024

Conversation

alexmojaki
Copy link
Contributor

@alexmojaki alexmojaki commented Mar 25, 2024

Change Summary

Make the hack in is_classvar work for strings like 'typing.ClassVar[...]', not just 'ClassVar[...]'.

Related issue number

Fixes #9069

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@alexmojaki alexmojaki added the relnotes-fix Used for bugfixes. label Mar 25, 2024
Copy link

codspeed-hq bot commented Mar 25, 2024

CodSpeed Performance Report

Merging #9097 will not alter performance

Comparing alex/inherit-pydantic_parent_namespace (31779cd) with main (f794f65)

Summary

✅ 10 untouched benchmarks

Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@sydney-runkle sydney-runkle merged commit 4af968d into main Mar 25, 2024
54 of 55 checks passed
@sydney-runkle sydney-runkle deleted the alex/inherit-__pydantic_parent_namespace__ branch March 25, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__future__ annotations with typing.ClassVar
3 participants