Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discriminated union bug with unsubstituted type var #9124

Merged
merged 1 commit into from Mar 27, 2024

Conversation

sydney-runkle
Copy link
Member

@sydney-runkle sydney-runkle commented Mar 27, 2024

Fix #9118, see test for details :).

Selected Reviewer: @davidhewitt

@sydney-runkle
Copy link
Member Author

Please review

Copy link

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8c33f06
Status: ✅  Deploy successful!
Preview URL: https://88755251.pydantic-docs2.pages.dev
Branch Preview URL: https://discriminator-fixes-again.pydantic-docs2.pages.dev

View logs

Copy link

codspeed-hq bot commented Mar 27, 2024

CodSpeed Performance Report

Merging #9124 will not alter performance

Comparing discriminator_fixes_again (8c33f06) with main (548feec)

Summary

✅ 13 untouched benchmarks

@sydney-runkle sydney-runkle enabled auto-merge (squash) March 27, 2024 17:29
@sydney-runkle sydney-runkle merged commit 7ac7881 into main Mar 27, 2024
52 of 54 checks passed
@sydney-runkle sydney-runkle deleted the discriminator_fixes_again branch March 27, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
3 participants