Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init private attributes from supertypes in model_post_init #9134

Merged
merged 1 commit into from Mar 29, 2024
Merged

Init private attributes from supertypes in model_post_init #9134

merged 1 commit into from Mar 29, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Mar 29, 2024

Fixes #9098

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 29, 2024 •
edited

CodSpeed Performance Report

Merging #9134 will not alter performance

Comparing Viicos:issue/9098 (358f24c) with main (b900fe2)

Summary

✅ 13 untouched benchmarks

@sydney-runkle sydney-runkle added the relnotes-fix Used for bugfixes. label Mar 29, 2024
sydney-runkle
sydney-runkle approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@sydney-runkle sydney-runkle merged commit 8128821 into pydantic:main Mar 29, 2024
53 of 54 checks passed
@Viicos Viicos deleted the issue/9098 branch March 29, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using a private attribute in model_post_init of subclass
2 participants
@Viicos @sydney-runkle