Update warnings parameter for serialization utilities to allow raising a warning
#9166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ydantic#8978 Signed-off-by: Lance-Drane <ldraneutk@gmail.com>
|
please review |
CodSpeed Performance ReportMerging #9166 will not alter performanceComparing Summary
|
…error_if_pydantic_core_mismatch
sydney-runkle
changed the title
warnings parameter for serialization utilities to allow raising a warning
sydney-runkle
approved these changes
Apr 11, 2024
Lance-Drane
deleted the
8978_serialization_error_if_pydantic_core_mismatch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This MR updates the type annotations and documentation for the warnings parameter of BaseModel.model_dump(), BaseModel.model_dump_json(), TypeAdapter.dump_python(), and TypeAdapter.dump_json(). The implementation logic was captured entirely in pydantic/pydantic-core#1258 , which has already been merged.
Note that the Pyright test will fail until the pydantic-core version is bumped.
Related issue number
#8978
Checklist
Selected Reviewer: @samuelcolvin