Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftp and Websocket connection strings support #9205

Merged
merged 5 commits into from Apr 14, 2024

Conversation

CherrySuryp
Copy link
Contributor

@CherrySuryp CherrySuryp commented Apr 10, 2024

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review

Hi everyone! I often use WS and FTP strings, so I thought it would be handy to add their validation to Pydantic. I think it should be useful for use when validating configurations in Pydantic Settings and for type annotations

@CherrySuryp
Copy link
Contributor Author

please review

Copy link

codspeed-hq bot commented Apr 10, 2024

CodSpeed Performance Report

Merging #9205 will not alter performance

Comparing CherrySuryp:ftp-and-websocket-support (3d46c0f) with main (a7d3253)

Summary

✅ 13 untouched benchmarks

@CherrySuryp
Copy link
Contributor Author

CherrySuryp commented Apr 10, 2024

Hello there! That's my first contribution to pydantic :)
As I understood from Release Instructions - relnotes have to be manually added by maintainers. That's why one of the CI checks didn't pass. Correct me if I'm wrong, thanks!

@sydney-runkle
Copy link
Member

Looks good! I think we might move these to pydantic-extra-types in V3, but I think it's fine to add them here for now.

@sydney-runkle sydney-runkle merged commit b844ea7 into pydantic:main Apr 14, 2024
53 of 54 checks passed
@CherrySuryp
Copy link
Contributor Author

CherrySuryp commented Apr 14, 2024

Yeah, I think it fits networking.py module well for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants