Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: make TypeAdapter example PEP-8 compliant #9268

Merged
merged 1 commit into from Apr 18, 2024
Merged

docs: make TypeAdapter example PEP-8 compliant #9268

merged 1 commit into from Apr 18, 2024

Conversation

vagenas
Copy link
Contributor

@vagenas vagenas commented Apr 17, 2024 •
edited by pydantic-hooky bot

Change Summary

Make TypeAdapter example PEP-8 compliant (variable should be in snake_case).

Related issue number

No issue created as change is trivial.

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist (ticked as not applicable)
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review

Selected Reviewer: @sydney-runkle

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 17, 2024

CodSpeed Performance Report

Merging #9268 will not alter performance

Comparing vagenas:fix-type-adapter-docs (2aa724f) with main (ae71183)

Summary

✅ 13 untouched benchmarks

@vagenas
Copy link
Contributor Author

vagenas commented Apr 17, 2024

please review

sydney-runkle
sydney-runkle approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@sydney-runkle sydney-runkle added the relnotes-ignore Omit this PR from the release notes. label Apr 18, 2024
@sydney-runkle sydney-runkle merged commit 3c15a8b into pydantic:main Apr 18, 2024
53 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees

@sydney-runkle sydney-runkle

Labels
ready for review relnotes-ignore Omit this PR from the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vagenas @sydney-runkle